https://meltano.com/ logo
#announcements
Title
# announcements
a

ancient-greece-23246

02/22/2021, 11:18 AM
They weren't kidding when they called it flakehell. Does anyone know how to get past these issues? Edit: aside from adding a docstring and lowercasing the variable name, of course
Copy code
poetry run flakehell lint src/ tests/
src/meltano/core/project_plugins_service.py:126:1: D102 Missing docstring in public method [flake8-docstrings]
  def find_plugin_by_namespace(
  ^
tests/meltano/core/test_schedule_service.py:37:6: N806 variable 'EXPECTED' in function should be lowercase [pep8-naming]
  EXPECTED = {"test": "custom", "start_date": None, "secure": None}
   ^
make: *** [Makefile:169: show_lint_python] Error 1
r

ripe-musician-59933

02/22/2021, 3:59 PM
@ancient-greece-23246 Why aside from doing what the error suggests? 😄 To make it easier for new contributors to learn what's going on, we're trying to add a docstring to every new/modified method/class/etc, so I'd suggest adding a simple one, and (apparently) naming conventions state that only module-level constants should be
UPPERCASE
, so I'd suggest changing that.