When should things be added (if ever) to the SDK’s

_singerlib

module? https://github.com/meltano/sdk/tree/main/singer_sdk/_singerlib Context: I am trying to add Python 3.11 support to tap-tableau. Currently that tap depends on the sdk version

^0.4.5

— python 3.11 support was added in

0.13.1

so I need to bump the sdk dependency at least that far, but would like to bring it to current

0.19.0

if possible. However, one of the sdk changes made since 0.4.5 was dropping the dependency on

singer-python

, and this tap depends on that package (transitively via the

sdk

dependency). It uses that

singer

package to format a datetime https://github.com/GtheSheep/tap-tableau/blob/main/tap_tableau/utils.py#L6 My question: I can’t have a dependency on both the current sdk and singer-python as they have incompatible dependencies on

jsonschema

. What’s the best way to proceed? 1. Add implementation of

singer.utils.strftime

to the sdk’s

_singerlib

package? 2. Implement that method directly in the tap, don’t propose any sdk changes? 3. something else?

When should things be added (if ever) to the SDK’s

_singerlib

module?

I’d say: as they’re needed. Option

1

is my preference (cc @aaronsteers @ken_payne), even alongside

2

if the sdk bump in the tap is urgent to address a bug or a security issue, for example.

the sdk bump in the tap is not urgent, just want to add 3.11 support so I can start using it. I’ll get an SDK PR together - thanks Edgar!

Awesome, thanks Matt!

Agreed with @edgar_ramirez_mondragon above. Thanks, @Matt Menzenski for this PR!