john_hwang
04/27/2022, 7:35 PM--state state.json
the code seems to always perform a full table replication. I’m unclear if the bookmarking state logic is built in, or if I need to implement it in sync() as I’m seeing with a lot of the existing metlano-optimized taps.edgar_ramirez_mondragon
04/27/2022, 11:13 PMjohn_hwang
04/28/2022, 6:44 PMjohn_hwang
04/28/2022, 8:39 PM{
"bookmarks": {
"rule_key": {
"replication_key": "p",
"replication_key_value": 25
}
}
}
When running the tap with this state passed in, I still see output records where “p” has values of 1 or 2 for example.edgar_ramirez_mondragon
04/28/2022, 11:10 PMget_starting_replication_key_value
or get_starting_timestamp
in your code? see https://sdk.meltano.com/en/latest/classes/singer_sdk.Stream.html?highlight=get_starting_replication_key_value#singer_sdk.Stream[…]lication_key_valuejohn_hwang
04/28/2022, 11:23 PMget_starting_replication_key_value
inside get_url_params, and print the results of the function. I get the expected replication_key_value of 25.edgar_ramirez_mondragon
04/28/2022, 11:23 PMjohn_hwang
04/28/2022, 11:25 PMjohn_hwang
04/29/2022, 4:26 PMjohn_hwang
04/29/2022, 9:14 PMedgar_ramirez_mondragon
04/29/2022, 10:29 PMI’m assuming I just have to manually implement the incremental replication?That is correct. It's up to the dev to implement the actual filtering that the source system expects 👍
Also, if it’s relevant, I’m running the tap using poetry rather than using meltano run or meltano elt.Yup, that should be alright.
john_hwang
04/29/2022, 11:01 PMedgar_ramirez_mondragon
04/29/2022, 11:02 PM