Is there a canonical way to raise log exceptions with the SD Meltano #singer-tap-development

Is there a canonical way to raise / log exceptions...

stephen_bailey

10/15/2021, 7:19 PM

Is there a canonical way to raise / log exceptions with the SDK when certain conditions are met? Wouldn't want to touch

_request_with_backoff

,a lthough this has some HTTP exception logic in it. My issue is that Slack will return a response of

Copy code

{
  "ok": false,
  "error": "not_in_channel"
}

And i'd like to reaise the

not_in_channel

error.

aaronsteers

10/15/2021, 8:03 PM

Some related discussions here: https://gitlab.com/meltano/sdk/-/issues/134

aaronsteers

10/15/2021, 8:04 PM

We definitely want to make a smoother path to this, with non-private methods to override.

aaronsteers

10/15/2021, 8:04 PM

cc @edgar_ramirez_mondragon

aaronsteers

10/15/2021, 8:05 PM

The short answer is that as of today, you'd probably need to override

_request_with_backoff

but in the future we'd either just make that public to encourage overriding or make certain parts of that abstract so that you can override just the parts you need to.

stephen_bailey

10/15/2021, 8:39 PM

Actually, since this is not a problem with the actual request and more of a problem with the response, I think i can add it into

parse_response

edgar_ramirez_mondragon

10/15/2021, 8:45 PM

@stephen_bailey I think we're going to implement an API very similar to what's described in https://gitlab.com/meltano/sdk/-/issues/207#note_666805849. Wdyt?

stephen_bailey

10/15/2021, 9:33 PM

Yes, that approach looks great to me!

Open in Slack

Previous Next