URL parameters are not included in the Metric log?

time=2021-09-09 11:02:52 name=tap-clickup level=INFO message=Params: {'page': 1}
time=2021-09-09 11:02:52 name=tap-clickup level=INFO message=INFO METRIC: {'type': 'timer', 'metric': 'http_request_duration', 'value': 0.506892, 'tags': {'endpoint': '/list/{list_id}/task', 'http_status_code': 200, 'status': 'succeeded', 'context': {'list_id': '132017099'}}}
time=2021-09-09 11:02:52 name=tap-clickup level=INFO message=Beginning full_table sync of 'folderless_task' with context: {'list_id': '132091655'}...
time=2021-09-09 11:02:52 name=tap-clickup level=INFO message=Params: {}
time=2021-09-09 11:02:53 name=tap-clickup level=INFO message=INFO METRIC: {'type': 'timer', 'metric': 'http_request_duration', 'value': 0.124969, 'tags': {'endpoint': '/list/{list_id}/task', 'http_status_code': 200, 'status': 'succeeded', 'context': {'list_id': '132091655'}}}

I added the log line in get_url_params as I was concerned the request wasn't going to the right place Welcome an issue or am I missing something?

Might not be secure since some APIs put tokens in the URL query 😅

duh I forgot about that! That's what I was missing 😄

@edgar_ramirez_mondragon nailed it. Originally we did log them, and then we removed that behavior because... auth tokens.

Got it the other option would be a whole system around safe / unsafe params and doing something like scrubbing them. I get it, I don't need them that bad

I don't have docs handy or a sample but I think some devs have been able to override the logging config just for the requests library, in order to get deeper visibility for debugging.

Yeah I think that was me a while back haha!

Oh! Ha! 😅