Would it be of interest to add `BasicAuthenticato...
# singer-tap-development
s
Would it be of interest to add
BasicAuthenticator
to the SDK? I have had to do this
base64
approach a couple times now, and it took me a bit to figure it out the first time:
Copy code
raw_credentials = f"{stream.config['username']}:{stream.config['password']}"
auth_token = base64.b64encode(raw_credentials.encode()).decode("ascii")
auth_headers = {"Authorization": f"Basic {auth_token}"}
d
I could鈥檝e sworn there was one already! That鈥檚 definitely one we should support out of the box
A contribution would be greatly appreciated 馃檪
v
I've done it twice as well! +1
s
thanks! i actually started working on this but had some confusion around the MR process basically because I'm not familiar with Gitlab. Should I: 1. fork the sdk within the gitlab ui 2. clone that locally 3. make edits 4. create the MR from my fork to the SDK? or can i just skip forking the repo? I assume i don't have permission but didn't want to test in prod 馃檪
d
That鈥檚 all correct! You won鈥檛 be able to push changes back into the main repo, so you need to fork it
a
Confirmed. 馃憤 And thanks!!