I have a question about this line in the sdk: <htt...
# singer-tap-developmentj
joshua_adeyemi
07/30/2021, 4:57 PMI have a question about this line in the sdk: https://gitlab.com/meltano/sdk/-/blob/main/singer_sdk/helpers/_typing.py#L25. Is there a reason the timezone is hardcoded there? I have run into a situation where when I pass it a timezone aware date, i end up with a datetime like this:
2021-07-28T15:08:23+00:00+00:00joshua_adeyemi
07/30/2021, 4:57 PMnot a blocker for me cause I worked around it, but curious
a
aaronsteers
07/30/2021, 7:00 PMHi, @joshua_adeyemi. Thanks for calling this out. I believe that specific line of code is "legacy" for us and was designed to make sure the UTC timezone is inferred when not otherwise specified. We would happily accept an issue, bug report, and/or MR if you would like to improve this. (I am actually surprised this has not already been reported by another developer.)
aaronsteers
07/30/2021, 7:01 PMActually, on looking closer, I would expect
.isoformat()val.isoformat() + "+00:00"aaronsteers
07/30/2021, 7:02 PM@edgar_ramirez_mondragon - Could you take a look and confirm?
aaronsteers
07/30/2021, 7:04 PMI see. By default, it looks like
.isoformat()aaronsteers
07/30/2021, 7:10 PMIf I understand this correctly, parsing from text will likely work as expected. But pre-building a datetime object may have the symptom described by @joshua_adeyemi, especially when the datetime object already is timezone aware.
j
joshua_adeyemi
07/30/2021, 7:12 PMyeah, thats what i ran into. I had to do extra parsing on my date object cause of another issue I ran into. Basically one of our ingestion sources was returning the date in this format
2021-07-29T23:26:08Z+0000joshua_adeyemi
07/30/2021, 7:13 PMSo I had to basically parse all those dates and set back to string in proper iso8601 format, which then trigged the
val.isoformat() + "+00:00"a
aaronsteers
07/30/2021, 7:22 PMI think there may be an expression that works in all cases, either using the Pendulum library or a version of
.isoformat()e
edgar_ramirez_mondragon
07/30/2021, 7:33 PMyup, it's a problem with naive datetimes in python:
Copy code
>>> import datetime
>>> datetime.datetime(2021, 1, 1).isoformat()
'2021-01-01T00:00:00'
>>> from pytz import timezone
>>> datetime.datetime(2021, 1, 1, tzinfo=timezone("UTC")).isoformat()
'2021-01-01T00:00:00+00:00'edgar_ramirez_mondragon
07/30/2021, 7:34 PMwe should be able to enforce tz-awareness in that function
a
aaronsteers
07/30/2021, 9:09 PMThanks, @edgar_ramirez_mondragon! Much appreciated.
aaronsteers
07/30/2021, 9:10 PM@joshua_adeyemi - Do you mind logging an issue for this? Sounds like we have a path forward and it will just be a matter of prioritizing.
j
joshua_adeyemi
07/30/2021, 11:09 PM