Trying to use streammaps, which branch do you reco...
# singer-tap-development
v
Trying to use streammaps, which branch do you recommend?
singer-sdk = { git = "<https://gitlab.com/meltano/sdk.git>", branch = "feature/target-base" }
Ran into
Copy code
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 783, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/visch/git/target-powerschoolapi/target_powerschoolapi/target.py", line 15, in <module>
    class TargetPowerschoolAPI(Target):
  File "/home/visch/git/target-powerschoolapi/target_powerschoolapi/target.py", line 19, in TargetPowerschoolAPI
    config_jsonschema = th.PropertiesList(
  File "/home/visch/git/target-powerschoolapi/.venv/lib/python3.8/site-packages/singer_sdk/typing.py", line 86, in to_dict
    return cast(dict, self.type_dict)
  File "/home/visch/git/target-powerschoolapi/.venv/lib/python3.8/site-packages/singer_sdk/typing.py", line 194, in type_dict
    merged_props.update(w.to_dict())
  File "/home/visch/git/target-powerschoolapi/.venv/lib/python3.8/site-packages/singer_sdk/typing.py", line 175, in to_dict
    type_dict = append_type(type_dict, "null")
  File "/home/visch/git/target-powerschoolapi/.venv/lib/python3.8/site-packages/singer_sdk/helpers/_typing.py", line 35, in append_type
    if "anyOf" in result:
TypeError: argument of type 'property' is not iterable
When adding stream_maps as an Object type
Fixed my issue by changing from
th.Property("stream_maps", th.ObjectType),
to
th.Property("stream_maps", th.ObjectType()),
a
@visch - Sorry for the delay. Yes, that looks correct. 👍
v
no problemo, Looks to be working for the most part with Stream maps going to dive in more tonight 🙂
Have at least 2 streams duplicating "seemingly" properly
Are we sure the target is setup to use stream maps? https://gitlab.com/meltano/sdk/-/merge_requests/4/diffs#note_608718152
a
Shortly will be... sorry for the confusion
v
Ok are we talking like a day, week, month?
a
Not weeks; I had some unexpecteds come up this week or would have been today/yesterday. End of week latest.
v
Ok thank you!! Appreciate all you're doing, I'll skip the stream maps part for now
a
Thanks, man. 👍 Will keep you posted.
There's been some cross-polination of those two MRs, because of the related nature and changes; however, this still might be delivered as 2 separate MRs.
v
got it, for me I can get by with adding DBT models in front of this it's just kinda silly for a few of them
a
Understood. I'm happy that your testing went well on the tap side, since the target implementation will leverage the same codebase for the similar functions.