Did you guys write a custom target for the hub? I ...
# singer-tap-developmentv
visch
05/20/2021, 8:36 PMDid you guys write a custom target for the hub? I heard you mention target-athena, I understand that normally you just push s3 files. End of the day I"m looking for an example of a target done with the singer_sdk to so if it's worth migrating my mssql target over yet.
visch
05/20/2021, 8:38 PMhttps://github.com/aaronsteers/target-athena ahh there it is
a
aaronsteers
05/20/2021, 8:45 PMYep, that’s it! We’ll be demoing tomorrow in #C01S996HGFK also. 👍
aaronsteers
05/20/2021, 8:48 PMI just double-checked and
mainaaronsteers
05/20/2021, 8:58 PM@visch - Just a heads up, based on our #C01QS0RV78D conversation yesterday, I am considering the following updates. These would not change anything in terms of design, just a question of what to call each method to be easiest to understand for new devs.
Copy code
Renames:
- Sink.load_record(record) -> process_record(record)
- Sink.drain(records) -> process_batch(records)
And a third method to be called within `process_record()` if it applies:
- Sink.append_batch_record()
And same as today, if the dev does not override `process_record()`, the default implementation auto-adds it for processing in batch.aaronsteers
05/20/2021, 8:59 PMHappy for your feedback and input.