Is this a bug or am I holding it wrong?
<https://g...
# singer-tap-developmentb
brandon_isom
04/08/2021, 10:55 PMIs this a bug or am I holding it wrong?
https://gitlab.com/meltano/singer-sdk/-/blob/main/singer_sdk/streams/core.py#L107
state Copy code
{
"replication_key": "some_column",
"replication_key_value": "2021-04-01T00:00:00Z"
}ifreplication_keyreplication_key_valuea
aaronsteers
04/08/2021, 10:56 PMConfirmed. That is a bug. Do you mind logging an issue?
b
brandon_isom
04/08/2021, 10:56 PMSure thing
a
aaronsteers
04/08/2021, 10:57 PMA previous version of the state implementation was using the bare attribute name in the state dictionary. It was changed in the other location but not here.
aaronsteers
04/08/2021, 10:58 PMThanks very much for reporting! You are welcome to submit a merge request, but this should be a quick fix and I can get to it shortly if not.
b
brandon_isom
04/08/2021, 11:00 PMI can probably get to it in the morning, have a few things to button up before I finish my day.
a
aaronsteers
04/08/2021, 11:01 PMGreat. And if I beat you to it, I’ll post back to this thread and also in the Issue.
b
brandon_isom
04/08/2021, 11:03 PMThank you!
a
aaronsteers
04/09/2021, 1:20 PM@brandon_isom Just a heads up that I logged the issue and started an MR, still in progress. Will post those links back here shortly.
b
brandon_isom
04/09/2021, 2:46 PMGlad I checked, heh
a
aaronsteers
04/09/2021, 8:05 PM@brandon_isom - This is resolved and ready for retest: https://gitlab.com/meltano/singer-sdk/-/merge_requests/58
aaronsteers
04/09/2021, 8:07 PMI also added a new test to confirm proper handling.
aaronsteers
04/09/2021, 8:10 PMLet me know if you are able to confirm using the
development