aaronsteers
01/02/2023, 9:07 PMedgar_ramirez_mondragon
01/02/2023, 10:23 PMUsers may run their test suite with warnings disabled for practical reasons, or deprecations may be triggered in code paths that are not covered by tests.
aaronsteers
01/02/2023, 10:54 PMaaronsteers
01/02/2023, 10:55 PMMatt Menzenski
01/02/2023, 11:24 PMWill Da Silva (Arch)
01/03/2023, 2:37 PMI've always thought the 'print deprecation warning log messages' a sub-ideal solution, since those are by their very nature going to be seen by users and very likely not seen by the developer.@aaronsteers @edgar_ramirez_mondragon Thoughts on making Pytest for Meltano fail if any warnings are emitted to prevent us from ignoring them? Meltano's test suite was passing with no warnings, but because checking them was a manual step someone merged a PR without checking them, and now several emit warnings: https://github.com/meltano/meltano/issues/6973. We could update the proposed resolution for that issue to include making Pytest fail if any warnings are emitted.
edgar_ramirez_mondragon
01/03/2023, 6:37 PMfilterwarnings
in the pytest settings, to fail on deprecation warnings (probably specific to the the library, we may not want them to fail on any deprecation warning). Relevant for: https://github.com/meltano/sdk/pull/1294