target-csv blows up with nested Objects, and CRLF...
# singer-targets
v
target-csv blows up with nested Objects, and CRLF. Is that the experience everyone else has?
by blows up I mean the File becomes unusable
a
I remember seeing similar on target-athena, which was based on target-csv. Do you mind opening an issue and/or an MR (if you have a fix)?
The root cause should be somewhere here: target-csv/sinks.py
I suspect the issue may be with the quote escaping, driven by
doublequote
and
escapechar
as described here: https://docs.python.org/3/library/csv.html#csv.Dialect.doublequote
v
a
v
hmm this looks nice! @axel Give this a shot with a CSV target , here's the meltano.yml
Copy code
plugins:
  loaders:
  - name: target-csv
    pip_url: git+<https://github.com/MeltanoLabs/target-csv>
    namespace: target_csv
    executable: target-csv
Tested with the Data we generated in target-athena and it all looked great. Dialect being set to Excel did the trick?
@aaronsteers is this good enough to replace https://hub.meltano.com/loaders/csv ?
Might want to get it updated for the new people!
a
Cc @taylor, @pat_nadolny. One thing I noticed is that our SDK-based MeltanoLabs implementation doesn't yet support flattening, while the hotglue variant does.
Also - this isn't necessarily a blocker, but we really should be publishing pinnable versions for all MeltanoLabs taps/targets. We don't have a script or pattern for this yet, unfortunately.