I noticed <https://gitlab.com/meltano/meltano/issu...
# announcements
l
I noticed https://gitlab.com/meltano/meltano/issues/1140 and it makes sense that this got deprio'd but maybe there's some local change I can make to the Caddyfile, or a patch I can apply to the app to stop it making assumptions about http vs https in the Vue.js frontend?
d
I 👀 this @luke_marsden and I'm thinking.
@luke_marsden Though I didn't initially set up our use of Axios, it looks like this may get you what you want https://github.com/axios/axios#global-axios-defaults.
main.js
is where this is initialized https://gitlab.com/meltano/meltano/blob/master/src%2Fwebapp%2Fsrc%2Fmain.js#L27
@micael_bergeron Is out sick, but has thought through this already. I know you shared the deprioritized issue, but maybe this specific comment would be of use too in case you missed it https://gitlab.com/meltano/meltano/issues/1140#note_232075640
@luke_marsden Do either of those options help?
l
Thanks @derek_knox! I'll ask one of my colleagues who knows Vue.js to comment on whether we can see how to fix this 🙂
I'll follow up tomorrow, probably. Appreciate the quick response - thanks!
d
No problem, the previous LoC was a bit off. Where the axios config occurs is actually https://gitlab.com/meltano/meltano/blob/master/src%2Fwebapp%2Fsrc%2Fmain.js#L44
If you end up forking and testing it. Let me know if it works and if so I can help get an MR in that would help you not have a fork of Meltano but also allows your setup to run w/o issue.
l
of course, we'll upstream a fix if we fix it 🙂
k
hey @derek_knox, tried experimenting a bit and fixed our current issue with browser blocking HTTP requests when user is with HTTPS: https://github.com/dotmesh-io/meltano/pull/4/files. This is a basic one, we can upstream it
however now I am looking airflow and even before seeing that issue with reverse proxy config I thought the same, we need to terminate it before and then route to a different port based on URL path
maybe even Flask itself could act as a reverse proxy
l
hey @karolis 👋 🙂
k
hi 😄
l
😄
d
@karolis Please do upstream it 🤘 . I unfortunately am not going to be much help on the reverse proxy comment. @micael_bergeron Is out, but he should be able to provide context when he's back.
Glad to see you and Luke have similar problems and a reusable solution that can make it back into Meltano core 😄
l
Karolis and I work together 🙂 - I just proposed his fix in this MR: https://gitlab.com/meltano/meltano/merge_requests/1163, we can move discussion to that perhaps?
d
Agreed, and thanks for the MR!