:wave: Hey folks - I ran into a fairly common issu...
# contributing
t
👋 Hey folks - I ran into a fairly common issue with a target I was working with (gupy-io/target-s3-parquet), where floating point validation can fail with an error like
ValidationError: 92.6 is not a multiple of 0.1
I found some discussion of this issue here and it sounds like the best approach is to convert floats to decimals prior to validation. The target in question relies on meltano/sdk to validate incoming records, so it seemed like a good idea to handle the conversion from floats to decimals within meltano/sdk, allowing developers to rely on meltano/sdk in this way while also handling this nuance. I made a PR and while there were a few checks that failed, I wanted to surface this and check in about the overall approach. Is this a PR you all would be supportive of, assuming I get all checks to pass etc? Any other feedback?
e
Hey @taylor_barstow! That target seems to be using an old version of the SDK: https://github.com/gupy-io/target-s3-parquet/blob/a8022b4eef8cf0e803d579a6e8c464d5f5df9b31/pyproject.toml#L15 My guess is that simply bumping the dependency will fix this issue, since this was addressed in https://github.com/meltano/sdk/pull/1809 and shipped with v0.29.0.
t
oh I see! ok thanks @edgar_ramirez_mondragon, I'll try that