Hiya folks I found an issue with oauth access token refresh Meltano #contributing

Hiya folks, I found an issue with oauth access tok...

jichao_sun

10/17/2023, 8:07 PM

Hiya folks, I found an issue with oauth access token refresh in tap-google-analytics, sent a fix here: https://github.com/MeltanoLabs/tap-google-analytics/pull/155

jichao_sun

10/17/2023, 8:15 PM

I did have a question: how are the per-setting env var defined in this page: https://hub.meltano.com/extractors/tap-ga4 generated? I noticed that when I was swapping to my own repo 1. I couldn’t just set TAP_GA4_{NEW_FIELD_I_ADDED}, it won’t propagate to config 2. I had to change from using variant to namespace, also had to add an

executable: tap-google-analytics

field for some reason (I’m guessing this is defined somewhere outside of the tap repo?) 3. Doing (2) made all the existing config env var mappings invalid, so I couldn’t keep using TAP_GA4_OAUTH_CREDENTIALS_ACCESS_TOKEN without manually defining the mapping in my meltano.yml file

pat_nadolny

10/18/2023, 8:08 PM

@jichao_sun yeah this is a little tricky. We have two versions of the tap listed on the hub that both reference the same git repo. We chose to keep the existing tap-google-analytics (UA) plugin on the hub and pin the pip url to a static branch before we updated to use GA4. Now we also have a GA4 plugin that references the git repo main branch. If you install the tap-ga4 plugin into your meltano project then update the pip_url to reference your fork, then run

meltano install extractor tap-ga4 --clean

you should have everything working as expected.

jichao_sun

10/19/2023, 11:57 PM

Thanks Pat!

jichao_sun

10/19/2023, 11:57 PM

Who should I go for a review on this PR?

pat_nadolny

10/20/2023, 1:12 PM

@jichao_sun me! 😄

Open in Slack

Previous Next