I'm keen to contribute to meltano docs, I have fol...
# contributing
m
I'm keen to contribute to meltano docs, I have followed the instructions here: https://github.com/meltano/meltano/tree/main/docs#contribute-to-the-docs However, I'm running into a problem with
main.scss
when I run
scripts/host_docs.sh
Copy code
Error: File to import not found or unreadable: node_modules/bulma/bulma. (Jekyll::Converters::Scss::SyntaxError)
Just checking here if anyone's seen this before posting an issue.
t
@mark_johnston not sure I can help with that error, but if you open a PR we have a Netlify job that will build a preview for you. We just have to approve it once it’s up. If you’re just going for content changes that’s probably easiest.
m
Thank you, been meaning to propose this for a while, tabs for meltano.yml vs meltano config vs .env: https://github.com/meltano/meltano/pull/7765
Not super confident it's going to work as it's not just changing text, but we'll see what the preview throws up?
t
I've triggered the build
https://deploy-preview-7765--meltano.netlify.app/concepts/plugins# looks like clicking config is bringing me to the top of the page
m
yes, I think it might be because I've simply called all the tab groups 'cli' - I will update them and try again
ok - that's done @taylor - do you need to approve for a rebuild?
t
I wish I could accept all builds for a PR… I have to do each one 🙄
m
Well - I am stumped, in the preview the existing tab group works and looks pretty much the same:
Copy code
<ul class="tab" data-tab="4f1737fa-7f79-420a-ad45-f92519f7f7fc" data-name="log">
  
      <li class="">
          <a href="#">Using pipx </a>
      </li>
  
      <li class="active">
          <a href="#">Using Docker </a>
      </li>
  
      <li>
          <a href="#">Using pip </a>
      </li>
  
</ul>
Not working:
Copy code
<ul class="tab" data-tab="fae1a54c-2ccf-4f4a-ab56-8b5e28a0be53" data-name="catalog">
  
      <li class="active">
          <a href="#">meltano.yml </a>
      </li>
  
      <li>
          <a href="#">config </a>
      </li>
  
</ul>
Class only appears on the
li
tag once clicked, so I don't think it's that
This appears at the end of the installation.md page, I have added it to the plugins page:
Copy code
<script src="/js/tabs.js"></script>
Sorry to be a pain, but could you rebuild please
t
looks like that fixed it!
I’ll take a look at it tomorrow and review / make suggestions. it’s way after hours for me here
thanks for sticking with it!
m
all good, hi from lunchtime Friday in Aotearoa NZ - almost the weekend! One suggestion is renaming the tabs back to all the same name so they're linked, if you click meltano.yml it sets all tabs to meltano.yml and vice versa for config
t
This is live! Thanks for the contribution 🎉 https://docs.meltano.com/concepts/plugins#metadata-extra