Hey Team, Thanks for transitioning <tap-smoke-tes...
# contributing
d
Hey Team, Thanks for transitioning tap-smoke-test to github. I wanted to make a few updates to lint the package and update its python version and opened a PR for it. I am planning on using this package to help test in target development. I saw @aaronsteers recently posted a new issue to standardize the included tests for tap/target here. Given these standard test changes are still in flight is my PR reviewable, or should I close and use my fork for the time being? New contrib to this project sorry if I missed something.
a
@dt_mirizzi - Thanks for the contribution! I did a quick review and approved from a high level. I'll let @edgar_ramirez_mondragon or another member of the team take a deeper dive as well.
That other issue I logged was more focused on making it easy to leverage those test cases as workloads for users - for instance to test downstream targets' ability to handle weird workloads. No need to block on that.
e
Merged. I also pushed a few commits to make sure it’s tested in all 3.8-3.11 Pythons 🙂. Thanks!
d
Thanks Y’all!