Thanks to <@U06BX9QQ4A3> for adding `mypy` <type c...
# contributing
a
Thanks to @edgar_ramirez_mondragon for adding
mypy
type checking in Meltano CI - which I think we will expand incrementally to cover increasing number of modules. New 🧵 to discuss.
@edgar_ramirez_mondragon - Thanks again for adding this - I was excited to see it land today. Do we have an issue yet for the follow on incremental expansion across modules? Any thoughts or suggestions on that?
e
I left a comment here to track the example PR: https://github.com/meltano/meltano/issues/6491#issuecomment-1238362855 But it’s probably worth tracking those in their own issue.
a
Yeah, I think a new top-level issue or a handful of separate issues (no more than 5, I think) would be helpful for our next steps.
Do you want to propose an incremental grouping of modules, and maybe engineers can opportunistically pick those up when they are touching those parts of the code base anyway?
e
Yeah, some modules will likely be harder to type than others because of volume and complexity. I’ll do an update to the contributor guide and create the top-level issue describing the process of including a subpackage or a single module in the mypy checks.