Refactoring `SQLConnector` to make catalog discove...
# contributinge
edgar_ramirez_mondragon
05/29/2022, 6:54 PMRefactoring
SQLConnectora
andrey_tatarinov
05/29/2022, 6:55 PMThis is me! 🙂
andrey_tatarinov
05/29/2022, 8:49 PM@edgar_ramirez_mondragon I think I managed to beat flake8 🙂
andrey_tatarinov
05/30/2022, 9:45 AM@edgar_ramirez_mondragon given that Meltano migrated to Github does it mean that PR should be recreated in GH?
w
Will Da Silva (Arch)
05/30/2022, 1:34 PM@andrey_tatarinov Yes. If the MR was already created, it should now link to a PR, or if it was not possible to create a PR, an issue that is a placeholder for it. We will be recreating every MR that was migrated into an issue to get them all open as PRs, but if you'd like to do that now by all means go ahead 🙂
Will Da Silva (Arch)
05/30/2022, 1:37 PMIf it was originally created using a fork of SDK on GitLab, you'll need to create a new fork off of GitHub. Then we can move your changes to the GitHub fork by adding it as a remote of your local clone. Assuming your GitLab remote repository is called `origin`:
Copy code
git remote set-url origin <github clone URL>Will Da Silva (Arch)
05/30/2022, 1:38 PMPlease let me know if you'd like some help or run into any trouble during this whole process. I'd be happy to help.
a
andrey_tatarinov
05/30/2022, 2:19 PMAll's good, moved PR to Github: https://github.com/meltano/sdk/pull/678
e
edgar_ramirez_mondragon
06/01/2022, 4:00 PMThis has been merged!
2 Views