Hi all! My team and I are working on a Meltano pro...
# contributing
b
Hi all! My team and I are working on a Meltano project for a client whose entire infrastructure is in Azure. Instead of using the default system database we want to use a mssql database. However, while doing so we've run into some migration issues. Has anyone else tried to configure meltano with a mssql database before and/or are there other people interested in this? Furthermore, as we are considering to contribute support for mssql databases to the meltano project, we'd be curious to hear whether there are any preferences/instructions on how to implement this functionality.
c
Hi @bernard_wezeman I gave it a quick test and I believe I can see the same isssue with a migration failing when trying to create the system db tables (
migrations/versions/b4c05e463b53_.py
,
CREATE TABLE plugin_settings
) I would be interested in having MSSQL support for the system database. I think it makes sense to have Meltano be a friendly citizen in an environment where a customer has a string "Microsoft SQL Server only" policy.
j
I think the problem is the fact that the String fields are not limited in length. I changed
sa.Column("name", sa.String(), nullable=False),
to
sa.Column("name", sa.String(450), nullable=False),
in the migrations, and it looks like everything works.
c
@jules_huisman Great find! I was simply dropping all the Primary Key and Uniqueness constraints to figure out if the migrations will run against Pymssql .... and yes, they will run when all the primary key and uniqueness constraints on unlimited length varchars are removed. 😉
f
I ran into something similar when I was trying to get it working with MySQL a few weeks ago. I ended up creating this issue: https://gitlab.com/meltano/meltano/-/issues/3315
a
Thanks Florian for logging and sharing that issue. @bernard_wezeman- We'd be very grateful for MR to open up other SQL backends if that is something you are able to contribute!
j
I'll probably have time next week to take a look at it!