Any pointers on this mr <https://gitlab.com/meltan...
# contributingv
visch
08/10/2021, 3:32 PMAny pointers on this mr https://gitlab.com/meltano/meltano/-/merge_requests/2247 ?
f
florian.hines
08/10/2021, 3:34 PMI missed the initial note on this one, but I can take a peek this afternoon.
florian.hines
08/10/2021, 3:36 PMjust double checking, but that exception if you’ve got listed in the issue is what you’re getting with your change set right (and not part of the original issue) ?
v
visch
08/10/2021, 3:36 PMyes! that's correct
f
florian.hines
08/10/2021, 3:39 PM👍 looks like a sneaky one - i’ll poke at it this afternoon and see if i can run it down
florian.hines
08/10/2021, 10:15 PMfyi - still waiting for all the tests to finish running locally, but with the latest suggested change I mentioned the elt tests pass now too.
v
visch
08/12/2021, 1:52 PMPRs good to go, passed tests, fixed merge conflict.
Hope it can make it into the next release (Today?)
f
florian.hines
08/12/2021, 2:52 PM👍 lgtm - we’ll just need one more approval from @aaronsteers and we can land it!
a
aaronsteers
08/12/2021, 5:50 PMOne new suggestion from @douwe_maan there in the MR 🙂
@florian.hines - since you are listed as approver there I'm happy for you to make the call. (Codeowners fix will come through shortly.)
6 Views