My other issue is that doing a tap-xero to loader-postgresql job, i get this issue: https://github.com/singer-io/tap-xero/issues/106 but i'm not across the schema spec enough to see what the issue is.

Smells like a target bug to me, are you using the meltanolabs variant? You should post an issue on the target side with an example record that fails

This seems like the Decimal bug to me (#344). We solved it in the target SDK.

if its fixed in the target sdk, what do i need to do as an end user to consume that fix?

Which target and variant are you using?

tap-xero and loader-postgres. the default variants on both

Ok, it seems MeltanoLabs/target-postgres is failing to automatically bump the singer-sdk dependency precisely because of the new Decimal serialization. I think I have a fix so I'll open a PR.

you probably just 10x's the speed of all the targets too Edgar

Wow, how did I do that? 😅

Just a gut feel so probably wrong, I haven't ran a performance test on target-postgres but my gut is the time is all in json deserializing , could be wrong but 🤷 simplejson is faster right? Maybe it's not? I guess I was thinking it was like rapidjson/orjson

Yeah I don't think simplejson is that much faster compared to stdlib's json, but once we drop Python 3.7 we can start looking seriously at continuously benchmarking all our serde operations.

isnt there a simd json thats crazy fast?

@joshua_hogendorn we're exploring a few alternatives in https://github.com/meltano/sdk/issues/1046