peter_pezon
12/16/2022, 11:47 PMmeltano elt
style logging should be deprecated │
│ 459 │ │ │ legacy_log_handler = self.output_logger.out("meltano", logger) │
│ 460 │ │ │ with legacy_log_handler.redirect_logging(): │
│ ❱ 461 │ │ │ │ await self.run_with_job() │
│ 462 │ │ │ │ return …Will Da Silva (Arch)
12/16/2022, 11:50 PMpeter_pezon
12/16/2022, 11:50 PMpeter_pezon
12/16/2022, 11:51 PMpeter_pezon
12/16/2022, 11:52 PMpeter_pezon
12/16/2022, 11:56 PMtarget-csv
(meltanolabs variant) implements process_batch
. would this help in copying only batches at a time from snowflake to csv? does the tap need to implement batch as well?Will Da Silva (Arch)
12/16/2022, 11:57 PMedgar_ramirez_mondragon
12/19/2022, 11:36 PMwould this help in copying only batches at a time from snowflake to csv?It doesn’t, unfortunately. It does process records in batches, but there’s nothing controlling the maximum batch size. Some targets allow you to fine tune this batch size, but that one doesn’t.
does the tap need to implement batch as well?@peter_pezon not necessarily. Most targets should be able to batch the records they read from stdin and commit them based on a few triggers, e.g. a SCHEMA message from a different stream or a STATE message. https://github.com/MeltanoLabs/target-csv/issues/3