michael_horvath
12/14/2022, 6:11 PMschema:
'dbo-Person':
OID:
type: ["null", "string"]
inclusion: available
However, the log shows WARNING Columns {'OID'} were selected but are not supported. Skipping them.
, and indeed when I check the output from invoking the tap I still don't see the OID field in the schema.michael_horvath
12/14/2022, 6:51 PM{
"tap_stream_id": "dbo-Person",
"table_name": "Person",
"schema": {
"properties": {
"OID": {
"type": [
"null",
"string"
],
"inclusion": "available"
},
"metadata": [
{ ...
{
"breadcrumb": [
"properties",
"OID"
],
"metadata": {
"selected-by-default": false,
"sql-datatype": "binary",
"selected": true
}
},
michael_horvath
12/14/2022, 6:58 PMBuzzCutNorman
12/14/2022, 7:54 PMBuzzCutNorman
12/14/2022, 8:29 PMmeltano --environment=<env you want> config tap-mssql set _meadata dbo-person.OID sql_datatype varchar
I tried it on a column in a test project and the command completed and it was added to the meltano.yml
.
- name: dev
config:
plugins:
extractors:
- name: tap-mssql
metadata:
dbo-testdata.testcolumn1:
sql_datatype: integer
michael_horvath
12/14/2022, 8:33 PM/venv/lib/python3.9/site-packages/meltano/core/settings_service.py:475: RuntimeWarning: Unknown setting '_metadata.dbo-person.OID.sql_datatype'
warnings.warn(f"Unknown setting {name!r}", RuntimeWarning)
michael_horvath
12/14/2022, 8:35 PMWARNING Columns {'OID'} were selected but are not supported. Skipping them.
michael_horvath
12/14/2022, 8:36 PMmichael_horvath
12/14/2022, 8:37 PMBuzzCutNorman
12/14/2022, 8:42 PMmichael_horvath
12/14/2022, 8:42 PMBuzzCutNorman
12/14/2022, 8:47 PMmichael_horvath
12/14/2022, 8:52 PMsteve_clarke
12/14/2022, 10:08 PMHi, I think that the intention is to support binary. It has logic to do this - the output is in a hex form.
<https://github.com/wintersrd/pipelinewise-tap-mssql/blob/e61e8687a552c8a6c67946b1c90f44745da90cb9/tap_mssql/sync_strategies/common.py#L123-L132>
I think however there needs to be an addition test inserted here <https://github.com/wintersrd/pipelinewise-tap-mssql/blob/e61e8687a552c8a6c67946b1c90f44745da90cb9/tap_mssql/__init__.py#L142> to support the binary column.
It wouldn't be too hard to add a PR to add support for the binary datatype. This would mean that tap-mssql would support the output of binary data as well.
michael_horvath
12/19/2022, 9:14 PMBuzzCutNorman
12/19/2022, 9:16 PMconfig:
dialect: mssql
driver_type: pyodbc
host: <yourserver>
port: 1433
user: <username>
database: <database>
sqlalchemy_eng_params:
fast_executemany: 'True'
sqlalchemy_url_query:
driver: ODBC Driver 18 for SQL Server
TrustServerCertificate: yes
BuzzCutNorman
12/19/2022, 9:20 PMset --interactive
when setting up tap and targets. meltano config tap-mssql set --interactive
michael_horvath
12/19/2022, 9:22 PMtejas
09/25/2023, 10:53 AMWARNING Columns {'my_column'} were selected but are not supported. Skipping them.
Is there a way that we can handle it in extractor
schema:
'my_table_name':
my_column:
type: ["null", "string"]
inclusion: available