https://linen.dev logo
Join Slack
Powered by
I’ve got a brand new, vanilla checkout of the sdk,...
# troubleshooting
f
I’ve got a brand new, vanilla checkout of the sdk, and im getting some pytest failures right out of the gate 🧵
Copy code
singer_sdk/plugin_base.py:187: RuntimeError
--------------------------------------------------------------------------------------------------- Captured stderr call ---------------------------------------------------------------------------------------------------
time=2021-08-18 12:29:05 name=sample-tap-gitlab level=INFO message=Parsing env var for settings config...
---------------------------------------------------------------------------------------------------- Captured log call -----------------------------------------------------------------------------------------------------
INFO     sample-tap-gitlab:plugin_base.py:78 Parsing env var for settings config...
================================================================================================= short test summary info ==================================================================================================
FAILED singer_sdk/tests/external/test_ga_init.py::test_tap_class - RuntimeError: Config validation failed: 'view_id' is a required property
FAILED singer_sdk/tests/external/test_ga_sync.py::test_ga_sync_sample - RuntimeError: Config validation failed: 'view_id' is a required property
FAILED singer_sdk/tests/external/test_generic_tests_external.py::test_gitlab_tap_standard_tests - RuntimeError: Config validation failed: 'auth_token' is a required property
FAILED singer_sdk/tests/external/test_generic_tests_external.py::test_ga_tap_standard_tests - RuntimeError: Config validation failed: 'view_id' is a required property
FAILED singer_sdk/tests/external/test_gitlab_discovery.py::test_gitlab_tap_discovery - RuntimeError: Config validation failed: 'auth_token' is a required property
FAILED singer_sdk/tests/external/test_gitlab_discovery.py::test_gitlab_replication_keys - RuntimeError: Config validation failed: 'auth_token' is a required property
FAILED singer_sdk/tests/external/test_gitlab_sync.py::test_gitlab_sync_all - RuntimeError: Config validation failed: 'auth_token' is a required property
FAILED singer_sdk/tests/external/test_gitlab_sync.py::test_gitlab_sync_epic_issues - RuntimeError: Config validation failed: 'auth_token' is a required property
============================================================================================== 8 failed, 35 passed in 13.05s ===============================================================================================
did a miss a setup/config step ?
s
I assumed those 8 tests required some sort of integration test configs. When I was editing my MR, the pipeline succeeded in the Gitlab server, but I got the same errors locally
e
That's correct but I think it's because it's ignoring them and running only these:
Copy code
poetry run pytest singer_sdk/tests/core
poetry run pytest singer_sdk/tests/cookiecutters
s
I think you can also run “poetry run tox “ which may contain some extra config
f
@stephen_bailey 👍 ah cool, i was actually checking it out so I could peek at your MR 😁
s
Giving you problems from the checkout, here we go 😂
a
@florian.hines - Thanks for flagging this. Originally, testing was more reliant on taps and targets which required external creds. You can search for files containing the suffix ".template" which in most cases will (should?) surface the secrets files needed for tests. Example here.
That said, we should do better on the new-contributor experience, either streamlining the input of needed external creds or better yet, perhaps excluding them by default.
Now that we have more tests that don't require creds, we might be able to remove some/most of these entirely.
j
a
Yes - I think that's right @joshua_adeyemi . I've logged a ticket to make a tag-based approach and improve docs.
j
Thanks
m
@edward_ryan, same issue they have faced earlier.
Open in Slack
PreviousNext
Powered by