Reuben (Matatika)
08/04/2021, 11:51 PMmeltano add <type> <name> --include-related
.
We have a custom file bundle files-google-analytics
set to the same namespace as the tap-google-analytics
extractor (tap_google_analytics
), which is defined in a custom `discovery.yml`:
files:
name: files-google-analytics
namespace: tap_google_analytics
repo: <repo-url>
pip_url: <pip-url>
When invoking meltano add extractor tap-google-analytics --include-related
, the file bundle files-google-analytics
is added twice, resulting in duplicated files.
If I provde the update
field with some arbitrary path (doesn’t even have to exist), then the command works as expected:
files:
name: files-google-analytics
namespace: tap_google_analytics
update:
<path>: true
repo: <repo-url>
pip_url: <pip-url>
After some reading, I found that update will default to an empty object ({}
) if not given. Setting update: {}
manually also causes the file bundle to add twice when adding tap-google-analytics
with --include-related
. This may indicate that there is some issue when a file bundle sharing a namespace
with the plugin being added, is itself added via --include-related
with update
set as an empty object (manually or by default).
...or am I missing something important here?douwe_maan
08/04/2021, 11:59 PM--include-related
, does it work as expected then? Matching file bundles are always installed, even when related plugins aren’t explicitly requesteddouwe_maan
08/04/2021, 11:59 PMmeltano add
log output also list files-google-analytics
twice?douwe_maan
08/04/2021, 11:59 PMReuben (Matatika)
08/05/2021, 12:18 AMIf you dropYes -, does it work as expected then?--include-related
--include-related
here installs the file bundle only once, as you say. We still need the dbt
transformer plugin and file bundle however, which we get by using --include-related
.
Does theYes - the following log output line appears twice:log output also listmeltano add
twice?files-google-analytics
Adding related file bundle 'files-google-analytics' to your Meltano project...
Reuben (Matatika)
08/05/2021, 12:19 AM