florian.hines
08/03/2022, 7:26 PMflorian.hines
08/03/2022, 7:27 PMflorian.hines
08/03/2022, 7:29 PMedgar_ramirez_mondragon
08/03/2022, 7:31 PMmeltano.extend
with public APIs or some common library both Meltano and plugins import, but I feel like the latter just means more work for us.Will Da Silva (Arch)
08/03/2022, 7:57 PMmeltano
that is included in a module's __all__
, does not begin with an underscore, and is not part of meltano.core
.Will Da Silva (Arch)
08/03/2022, 7:58 PMflorian.hines
08/03/2022, 8:00 PMaaronsteers
08/03/2022, 8:22 PMThose are all things we could spin out into a general purpose meltano utility package if we really needed to DRY things up but didn't want folks importing from meltano.core.
I think that’s the desirable approach. ... have them import from something likeThis is the direction I'd lean towards also. Ideally thewith public APIs...meltano.extend
meltano
namespace would be clean but it's not as of now. Also, even if it were clean, I'd feel better about dependencies on a helper library or helper module for this specific use case - rather than depending directly on the meltano python libraries as an external API (read: an API needing to remain stable).aaronsteers
08/03/2022, 8:23 PMmeltano-core
or meltano-utils
or something like that with minimal external dependencies would be ideal when it comes to what another Python library might reasonably import for interop reasons.aaronsteers
08/03/2022, 8:25 PMflorian.hines
08/03/2022, 9:04 PMflorian.hines
08/03/2022, 9:04 PMaaronsteers
08/03/2022, 9:06 PMflorian.hines
08/03/2022, 9:07 PMaaronsteers
08/03/2022, 9:07 PMaaronsteers
08/03/2022, 9:09 PM