Kind reminder - would anyone from owners be willin...
# show-us-what-you-gotj
jan_soubusta
04/03/2023, 7:05 AMKind reminder - would anyone from owners be willing to merge my PR?
https://github.com/MeltanoLabs/tap-salesforce/pull/34
At least, I would appreciate if you merge the first commit, it speeds up the discovery a LOT.
If you are not OK with the second commit, I can remove it and workaround it with overriding the metadata in maltano.yml.
d
dan_ladd
04/03/2023, 1:03 PMHey Jan, I don't see an issue with the first commit, but I would like to look more into the second one. That might impact people using the tap today.
dan_ladd
04/03/2023, 1:03 PMIf you could remove the second commit and Ideally add the new config property to the readme, I can approve
j
jan_soubusta
04/03/2023, 2:05 PMDone, please, approve.
jan_soubusta
04/03/2023, 2:06 PMMay I kindly ask you for showing me a simple example how to override the metadata from the meltano.yml to do not need the commit I removed?
d
dan_ladd
04/03/2023, 2:11 PMok, all set on the MR. Not sure what you are asking in regard to the meltano.yml
j
jan_soubusta
04/03/2023, 2:15 PMCurrently, anyType Salesforce properties are not transferred to targets. The second commit solves it.
Other people here in the community suggest me to override the metadata for the Salesforce in meltano.yml to enforce the type of affected properties so they are loaded to targets.
jan_soubusta
04/03/2023, 2:16 PMI guess they meant this:
https://docs.meltano.com/concepts/plugins#metadata-extra
jan_soubusta
04/03/2023, 2:17 PMIn my case, e.g. LeadHistory.OldValue is of anyType.
So my guess is that if I specify the following in the meltano.yml, it should work even without the second commit:
Copy code
extractors:
- name: tap-salesforce
metadata:
LeadHistory:
OldValue:
type: ["string", "null"]jan_soubusta
04/03/2023, 2:18 PMIs my guess correct?
d
dan_ladd
04/03/2023, 4:55 PMI haven't tried using this in meltano, so I'm not sure.
i
isaiah_morgan
04/03/2023, 5:46 PMHey all, I submitted a PR on this https://github.com/MeltanoLabs/tap-salesforce/pull/35 to fix the type hinting
j
jan_soubusta
04/04/2023, 7:15 AMEh, sorry, I always forget to add this import, because I am using newest Python versions for a long time 😉
7 Views