Hello folks! New to contributing to Meltano, quit...
# contributing
r
Hello folks! New to contributing to Meltano, quite excited! We are currently using several taps and targets from Transferwise and we would like to migrate to the ones that use the Meltano SDK, which we are more familiar with and we feel more comfortable to contribute to. We are starting the migration with Target Postgres. 1. As somebody pointed out, it seems that this target was heavily customized (overrode several methods of the Meltano SDK), and I am not sure to what extent this is still necessary. And we would need this (
load_method
=
overwrite
, which we would get out of the box with the current version of the SDK). I posted a comment here and I am willing to take over the refactor. 2. The column caching seems to throw wrong results on schema changes. I also posted my opinion here Looking forward to contributing!
👋 1
v
Hey Raul! Welcome and I hope for this all to be as easy as possible. Are you sure you need the
load_method
piece if you're migrating from pipelinewise? Activate version works in the target (not the meltanolabs tap as there's a singer_sdk issue in for that) so it' be interesting to dive into that use case a bit The caching implementation portion we could override fairly easily in
target-postgres
, best next step would be a failing test I think 😄
r
Hello @visch Sorry, I have been sick and have not followed up on this! So, several comments on this: 1. We are currently not leveraging the Activate Version in the pipelinewise tap, and I was migrating our current setup "as is". 2. In any case, we are planning on migrating to the Tap Postgres of Meltanolabs too, and it seems it is not a supported feature you are saying. 3. I was under the impression that Activate Version was a relatively new feature and decided not to implement too many new things in a single go. 4. Soft Delete Activate Version tests are sometimes failing in the
target-postgres
as well; I have not identified yet under which circumstances they fail. To sum-up: I decided to postpone for a new iteration the implementation of Activate Version. About the caching implementation: I think that this is something that has to be fixed on the Meltano SDK repository, rather than the target postgres. In fact, in the current implementation of the target tests are not failing precisely because this part of the code is overridden. In any case, I posted the failing tests in a comment here
👀 1