Hi All, Is there a reason why Custom Flattening Se...
# singer-tap-development
s
Hi All, Is there a reason why Custom Flattening Separator is not set as plugin configuration, I can see the default option to be "__", Is this due to any limitations in different targets. I am curious why __ why not just _
a
PErsonally, I would use
_
as a whitespace replacement in keys, so using
__
as a flattening separator helps distinguish between a key and a level.
my_key_level_name
vs
my_key__level_name
2
e
I feel like making it configurable would be a big 🦶🔫 .
s
got it, I see a column name like this("JSONPAYLOAD__AUTOCOMPLETE__SESSIONTRACKINGTOKEN ") and I am like can this be pretty , but I see the use case now , differentiate flattened column from others
a
Yes you can infer (or even reconstruct!) the original json schema.
@Edgar Ramírez (Arch.dev) definitely an issue if the tap defines primary keys assuming that flattening will happen. I don't know if that's a common issue but found that with google ads, took me a while to figure out what was going on. https://github.com/Matatika/tap-googleads/issues/12
👀 1