:wave: I'm working towards a PR to change tap-gith...
# contributing
t
👋 I'm working towards a PR to change tap-github's authenticator to enable refreshing for github app tokens, and as far as I can tell there are no tests for anything in the authenticator file. Is that fairly standard practice, or should I be trying to add tests for the changes I'm making (and if so, is there an example of authenticator tests in another tap that would be good to study up on)?
e
Is that fairly standard practice, or should I be trying to add tests for the changes
I'd say it's rather common to not test units like auth. Though I've tried to encourage testing things like pagination, etc. by decoupling them from the tap classes. Auth falls in that category, and I'd love to have more examples of auth unit tests.