https://linen.dev logo
Join Slack
Powered by
I created a small Pull Request to improve column q...
# meltano-plugin-development
h
I created a small Pull Request to improve column quoting in the meltano SDK. https://github.com/meltano/sdk/pull/2582 I appreciate your reviews on it. In general object quoting feels a bit brittle, because in some methods custom queries are constructed using parts generated by sqlalchemy, while other methods, sqlalchemy is used entirely. I'll try to make some improvements in that regard as well.
đź‘€ 1
e
Thank you @haleemur_ali, I'll try to take a look today 🙂
❤️ 1
h
Thank you for merging this in
hey @Edgar RamĂ­rez (Arch.dev), after some more testing i found a fault with my code, and will be submitting a fix in the next 20 minutes.
e
Gotcha, thanks! That also means there's a gap in our tests?
h
Yes, in this case, the gap is due to how different database engines quote objects.
The fix is straightforward. This
Copy code
compiled = create_column_clause.compile(self._engine)
should be
Copy code
compiled = create_column_clause.compile(self._engine).string
adding a test would take me a bit longer as i've not done that yet, and there seems to be quite a bit of redirect happening in 
StandardTargetTests
and i'll likely be a bit slow to grok it.
when is the next release planned? I'll prioritize working on the fix & test accordingly (ideally in the same pull request, but if we're set to cut a release next monday, then I'd prefer to submit the fix right now)
new pull request fixing this issue with tests https://github.com/meltano/sdk/pull/2583
4 Views
Open in Slack
PreviousNext
Powered by