Edgar RamÃrez (Arch.dev)
10/30/2024, 9:49 PMvisch
10/31/2024, 12:48 PMNOTYPE
Is a valuable construct I think as it allows folks to take some json format they are struggling to get into their target (or they could do this for everything) and map it to something that just trys to convert us to a string. See https://github.com/MeltanoLabs/target-postgres/blob/422286df28b55184ed8f0535327007b5c246b17f/target_postgres/connector.py#L264C20-L264C26 and the NoType, SqlAlchemy type here https://github.com/MeltanoLabs/target-postgres/blob/422286df28b55184ed8f0535327007b5c246b17f/target_postgres/connector.py#L857-L879visch
10/31/2024, 12:49 PMvisch
10/31/2024, 12:49 PMEdgar RamÃrez (Arch.dev)
11/06/2024, 12:16 AMYup, the PR doesn't get rid of that. I want (at some point) to add snapshot tests to stuff in MeltanoLabs to safeguard a bit more against regressions in things like discovery and, in the case of target-postgres, SQL schema generation.Is a valuable construct I think as it allows folks to take some json format they are struggling to get into their target (or they could do this for everything) and map it to something that just trys to convert us to a string.NOTYPE
Another one is allowing configuration to override the type mappings is very useful is some situations like if you want numbers to be Decimals or something (I can list out the use cases it'll just take me too much time right now) See the list hereYeah, since the new API is just a class it's really easy to subclass it and accept arbitrary init args from the target.
Generating the Readme for datatype mappings from this function see the readmeThat's a good one, I'll see if it needs updates though I think not