Hi all, so I'm trying to upgrade Meltano (to 3.6) ...
# troubleshooting
j
Hi all, so I'm trying to upgrade Meltano (to 3.6) and Dagster to (1.9.6) and Dagster started spewing the following error, was hoping to get an insight as to what's going on đŸ§” .
👀 1
Copy code
5-01-06 12:27:11 
2025-01-06 12:27:11 Extension executing `dbt deps`...
2025-01-06 12:27:13 17:27:13  Running with dbt=1.8.9
2025-01-06 12:27:13 17:27:13  Installing dbt-labs/dbt_utils
2025-01-06 12:27:13 17:27:13  Installed from version 1.3.0
2025-01-06 12:27:13 17:27:13  Up to date!
2025-01-06 12:27:13 17:27:13  Installing calogica/dbt_expectations
2025-01-06 12:27:15 17:27:15  Installed from version 0.10.4
2025-01-06 12:27:15 17:27:15  Up to date!
2025-01-06 12:27:15 17:27:15  Installing calogica/dbt_date
2025-01-06 12:27:15 17:27:15  Installed from version 0.10.1
2025-01-06 12:27:15 17:27:15  Up to date!
2025-01-06 12:27:15 
2025-01-06 12:27:15 
2025-01-06 12:27:15 Extension executing `dbt parse`...
2025-01-06 12:27:51 
2025-01-06 12:27:51 
2025-01-06 12:27:53 2025-01-06T17:27:53.265604Z [info     ] Environment 'dev' is active   
2025-01-06 12:27:53 Traceback (most recent call last):
2025-01-06 12:27:53   File "/project/.meltano/utilities/dagster/venv/bin/dagster_invoker", line 5, in <module>
2025-01-06 12:27:53     from dagster_ext.pass_through import pass_through_cli_dagster
2025-01-06 12:27:53   File "/project/.meltano/utilities/dagster/venv/lib/python3.11/site-packages/dagster_ext/pass_through.py", line 7, in <module>
2025-01-06 12:27:53     from dagster_ext.extension import Dagster
2025-01-06 12:27:53   File "/project/.meltano/utilities/dagster/venv/lib/python3.11/site-packages/dagster_ext/extension.py", line 21, in <module>
2025-01-06 12:27:53     from meltano.edk import models
2025-01-06 12:27:53   File "/project/.meltano/utilities/dagster/venv/lib/python3.11/site-packages/meltano/edk/models.py", line 16, in <module>
2025-01-06 12:27:53     class ExtensionCommand(Command):
2025-01-06 12:27:53   File "/project/.meltano/utilities/dagster/venv/lib/python3.11/site-packages/pydantic/_internal/_model_construction.py", line 115, in __new__
2025-01-06 12:27:53     private_attributes = inspect_namespace(
2025-01-06 12:27:53                          ^^^^^^^^^^^^^^^^^^
2025-01-06 12:27:53   File "/project/.meltano/utilities/dagster/venv/lib/python3.11/site-packages/pydantic/_internal/_model_construction.py", line 418, in inspect_namespace
2025-01-06 12:27:53     raise PydanticUserError(
2025-01-06 12:27:53 pydantic.errors.PydanticUserError: Field 'description' defined on a base class was overridden by a non-annotated attribute. All field definitions, including overrides, require a type annotation.
2025-01-06 12:27:53 
2025-01-06 12:27:53 For further information visit <https://errors.pydantic.dev/2.9/u/model-field-overridden>
2025-01-06 12:27:56 2025-01-06T17:27:56.546334Z [info     ] Environment 'dev' is active   
2025-01-06 12:27:56 Extension executing `dbt clean`...
This happens when I try to start up dagster itself from the container . I currently don't have problems with dagster when I am on version 1.8.13 (slightly older)
Field 'description' defined on a base class was overridden by a non-annotated attribute. All field definitions, including overrides, require a type annotation.
i am not sure why this all of a sudden would be an issue; I assume it's line 20 for the
ExtensionCommand
?
It may have to do with the dagster-ext 0.1.2 using the newer version of pydantic and catching something...?
Yeah I think it's that, i kept all of my original code and only upped the dagster-ext to 0.1.2, which is now causing the error to appear 😞
I'm noticing that the dagster-ext has a whole spearate
meltano\edk
subfolder, where it's missing a
:str
...shouldn't the package be using the https://github.com/meltano/edk instead of locally as a subfolder???
e
I'm not sure what motivated vendoring the EDK, but yeah, adding the missing annotation there should fix this
j
I'm hoping this is the only change needed >_<
Thanks for confirming Edgar
Edgar, would you be able to double check my wording https://github.com/quantile-development/dagster-ext/issues/16 if there's anything missing or incorrect here? I think I got the essence of the problem written down
👀 1
e
The issue and PR look good. Can you confirm the changes fix the problem?
j
I will need to figure out how to get the forked repo as a pip url. I haven't done anything like that before ^^;;. Will try something later this week where time permitsb
e
This should do the trick
Copy code
pip_url: git+<https://github.com/joshua-janicas/dagster-ext.git@feature/PydanticUpdateFixes>
melty bouncy 1
j
That worked! Thanks Edgar melty bouncy . I confirmed that I was able to load Dagster on 1.9.6
will post screenshots in the pr
e
nice!