Hi <@U06CEG44Y04> just wondered if you had any luc...
# infra-deployment
a
Hi @Matt Menzenski just wondered if you had any luck looking at the
dagster-meltano
change? Ended up in a bit of jam last week where our dagster alerts stopped working but I couldn't update to dg 1.10.x because of the meltano issue :S
m
I haven’t yet had time for this. It’ll probably be another two or three weeks before I am able to really look into it.
a
No worries, appreciate anything you can do. Well out of my depth on this one!
m
@Andy Carter I’ve now got a fork with an implementation that uses the new PipesSubprocessClient. This is very much an “alpha” stage - I am just beginning to test it locally, haven’t yet tried to run it “for real”. https://github.com/menzenski/dagster-meltano/tree/to-dagster-pipes
🙌 1
👀 1
so, this doesn’t work 😕
can’t get the exit code and log messages from the Pipes client in the way that dagster-shell allows.
I think it’ll be a simple fix to get the command working, but maybe that’s at the expense of the exit code and logs
I need to spend more time with this
j
just wanted to say that i was digging around for help after i had trouble upgrading to dagster 1.10 - i think i have the same problem with the deprecation of dagster_shell. thanks matt for trying to take a look at this!
👍 1
m
The latest news on my side is that I think substituting the dagster-shell call for a PipesSubProcessCall is actually pretty simple/straightforward, if all you care about is that the job runs. But the current dagster-meltano implementation gets the logs (stdout lines) and exit code from the dagster-shell command and returns it to the caller, and the PipesSubprocessClient doesn’t provide a way to that that I have found. I’d like to experiment with providing Meltano a custom log handler that uses the Dagster PipeContext to send logs back to Dagster - I think that if the
dagster-pipes
library is installed in meltano’s virtual environment, and meltano is configured to use that custom log handler, that we could use the PipesSubprocessClient to invoke Meltano and still get meltano logs in Dagster, but I haven’t tried this yet.
meltano 2
❤️ 2
a
Thanks so much for the work on this. I wonder whether it is worthwhile engaging the dagster devs /community on this too? They highlight meltano as an integration via this library.
m
I have been in touch with them, a bit https://dagster.slack.com/archives/C08HFHSDAJJ/p1745426942884829 I need to follow up with Colton
a
Can't access that link, is it a private channel?
m
It’s in the Dagster community Slack (in the #dg-components channel, which is public there)
🙌 1
j
Hey Matt, just checking if there's a timeline you're thinking of for the changes?
m
I am hoping to have time to dig into this again next week
❤️ 1
👍 1
🙌 1
a
Happy to help with some testing as and when it might help.
m
I still haven’t figured this out. I’ve opened an issue in the Dagster repo https://github.com/dagster-io/dagster/issues/30209
🤔 1
👌 2
👀 1
trying a new strategy, I think this is better
j
Hey Matt, just checking if you'd had any luck with the PR above or if you are looking for help testing wise
👀 1
Hey there; sorry to be a bother but I was wondering if any luck with PR 58. I'm a bit concerned because the maintainer (Jules) (https://github.com/JulesHuisman) profile has been wiped out - I have a feeling that he's moved on to different things and now as a result there's potentially no maintainers/people who can merge for us for https://github.com/quantile-development/dagster-ext / https://github.com/quantile-development/dagster-meltano. So even once this is ready to go I don't know if we are able to get it merged 😰
🤯 1
a
Hope there is some way to get this resolved thanks @joshua_janicas