Hi <@U06CASRQ0H0>, do we have a plan to suppress t...
# singer-tap-development
s
Hi @Edgar Ramírez (Arch.dev), do we have a plan to suppress this message when we have additionalProperties set to true? This method was designed to validate date types, but the error message about the missing key in the schema is being spammed for cases where additionalProperties is set to true. The fix seems quite straightforward: adding a condition to check if "additionalProperties" is true, then suppressing the warning "No schema for record field." Please let me know if this message serves a different purpose that might conflict with skipping it by checking "additionalProperties." https://github.com/meltano/sdk/blob/fdeb393416f0d1935e40c28b91c800c9d1b40822/singer_sdk/sinks/core.py#L588 fix : https://github.com/SidduHussain/sdk/blob/f99ecab90770932829f138aece164ad7d4196115/singer_sdk/sinks/core.py#L587
e
That change makes sense to me @Siddu Hussain, PRs welcome!
s
@Edgar Ramírez (Arch.dev) -- done https://github.com/meltano/sdk/pull/3031
@Edgar Ramírez (Arch.dev), Sorry for the trouble. Problems I face due to the urge to refactor at the last minute. 🤦 I found the issue and fixed it. Should I raise a new PR, as the current one is merged? https://github.com/SidduHussain/sdk/blob/328931a639148f5aca3874cfa19b8fe22d2bbf27/singer_sdk/sinks/core.py#L588