<#3153 refactor: Read config files early> Pull req...
# meltano-repo-activity
g
#3153 refactor: Read config files early Pull request opened by edgarrmondragon ## Related • Supersedes #3143. ## Summary by Sourcery Refactor configuration handling to merge JSON config files early and propagate a unified config dictionary throughout plugins, taps, mappers, and targets Bug Fixes: • Change
read_json_file
to raise
FileNotFoundError
instead of
FileExistsError
for missing files Enhancements: • Replace
_ConfigInput.files
with a merged
config
dictionary and a
parse_env
flag • Update
from_cli_args
to read and merge JSON files sequentially and recognize an "ENV" marker • Propagate the new config dict in
SingerCommand
,
tap_base
,
mapper_base
, and
target_base
instead of file lists • Mark the old
config_from_cli_args
code paths as no-cover since they are no longer used Tests: • Revise tests to assert on merged config dict contents and updated error messages --- 📚 Documentation preview 📚: https://meltano-sdk--3153.org.readthedocs.build/en/3153/ ## Summary by Sourcery Refactor config loading to merge JSON config files early into a unified dictionary and propagate it through all plugin bases, while updating tests and error handling accordingly. Bug Fixes: • Have read_json_file raise FileNotFoundError instead of FileExistsError when a file is missing Enhancements: • Replace _ConfigInput.files with a merged config dictionary and parse_env flag • Update _ConfigInput.from_cli_args to sequentially merge JSON files and detect an “ENV” marker • Propagate the new config dictionary in SingerCommand, tap, mapper, and target bases instead of file lists • Mark the old config_from_cli_args code paths as no-cover deprecation Tests: • Revise tests to verify merged config dictionary contents and updated error messages meltano/sdk