GitHub
07/04/2025, 5:34 PMmeltano remove no longer requires specifying a plugin type, i.e. meltano remove tap-github works too
Pull request opened by edgarrmondragon
## Description
## Related Issues
• #9317
• #7066
## Summary by Sourcery
Allow meltano remove to accept plugin names directly and infer their types, introduce a --plugin-type flag, deprecate the old positional type argument with a warning, and centralize plugin type inference logic.
New Features:
• Allow omitting the plugin type when running meltano remove by inferring types from names
• Add a --plugin-type option to the remove command
• Emit a deprecation warning when the plugin type is passed as the first positional argument
Enhancements:
• Extract and reuse infer_plugin_type and PluginTypeArg into the CLI utils module
• Refactor the remove command signature to accept only plugin names and derive types as needed
• Replace the private _infer_plugin_type in add with the shared infer_plugin_type function
Tests:
• Add tests for removing plugins without specifying a type
• Update existing remove tests to expect a DeprecationWarning for positional type arguments
• Add a test for the explicit --plugin-type usage
## Summary by Sourcery
Update the meltano remove command to infer plugin types automatically, introduce an explicit --plugin-type flag, emit deprecation warnings for the old positional type argument, centralize inference logic in shared utilities, update tests, and refresh documentation accordingly.
New Features:
• Allow omitting the plugin type for meltano remove by inferring it from plugin names
• Add a --plugin-type option to the remove command
• Deprecate the positional plugin type argument with a warning
Enhancements:
• Extract infer_plugin_type and PluginTypeArg into a shared CLI utils module
• Refactor the add and remove commands to use centralized plugin type inference
Documentation:
• Update CLI reference and guides to reflect the new inferred plugin type syntax and deprecate the old usage
Tests:
• Add tests for removing plugins without type or with the explicit --plugin-type flag
• Update existing tests to expect a DeprecationWarning for the old syntax
meltano/meltanoGitHub
07/04/2025, 5:34 PMGitHub
07/04/2025, 5:57 PM