<#3424 Consider adding a new setting kind `decimal...
# meltano-repo-activity
g
#3424 Consider adding a new setting kind
decimal
Issue created by MeltyBot Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/3508 Originally created by @edgarrmondragon on 2022-05-19 011639 --- ### Problem to solve Allow developers to declare plugins with numeric settings that don't really fit any of the currently supported types. ### Target audience Plugin developers that require numeric settings. ### Further details One example that comes to mind is Unix timestamps with decimal precision. ### Proposal Meltano currently supports the following setting types: • oauth • hidden • password • date_iso8601 • file • email • integer • options • object • array • boolean • string A
decimal
type, cast to Python's
decimal.Decimal
is easy to add. Alternatives to the
decimal
name are:
real
,
number
,
numeric
. ### What does success look like, and how can we measure that? A new setting kind with support for ### Regression test • Write adequate test cases and submit test results • Test results should be reviewed by a person from the team ### Links / references • Cast logic: https://gitlab.com/meltano/meltano/-/blob/6d96c9bc9ec5610d87dc01d568bbdb3b162210a4/src/meltano/core/setting_definition.py#L188-212 •
SettingKind
enum: https://gitlab.com/meltano/meltano/-/blob/6d96c9bc9ec5610d87dc01d568bbdb3b162210a4/src/meltano/core/setting_definition.py#L62-76 meltano/meltano