<#3172 refactor: Use explicit submodule imports> P...
# meltano-repo-activity
g
#3172 refactor: Use explicit submodule imports Pull request opened by edgarrmondragon • python/typeshed#14246 (comment) • astral-sh/ty#133 • https://microsoft.github.io/pyright/#/import-statements?id=unsupported-loader-side-effects ## Summary by Sourcery Refactor SQLAlchemy usage to explicitly import and reference its submodules, update type hints and function calls accordingly, and adjust streaming message construction for improved type checking and compatibility. Enhancements: • Replace generic
sa.types
usages with explicit
sqlalchemy.types
imports and references across connectors, sinks, streams, and typing modules • Update SQLAlchemy calls (create_engine, Table, CreateSchema, CreateColumn, etc.) to use fully qualified submodule paths (e.g.,
sqlalchemy.create_engine
,
ddl.CreateSchema
) • Import and utilize
sqlalchemy.sql.selectable.Select
for stream query signatures instead of
sa.sql.Select
• Refactor ActivateVersionMessage to use keyword arguments (
stream=
and
version=
) • Switch reflection types to
reflection.Inspector
,
ReflectedColumn
,
ReflectedIndex
, and
ReflectedPrimaryKeyConstraint
for clarity and type safety meltano/sdk