<#2262 feat: Make SQLConnector _connect function p...
# meltano-repo-activity
g
#2262 feat: Make SQLConnector _connect function public Issue created by visch ### Feature scope Taps (catalog, state, stream maps, tests, etc.) ### Description The function here sdk/singer_sdk/connectors/sql.py Lines 82 to 85 in</meltano/sdk/commit/0285704e71dd9bce573c8c518b8ce3287943ce94|0285704> | @contextmanager | | --------------------------------------------------------------------------- | | def _connect(self) -> t.Iterator[sa.engine.Connection]: | | with self._engine.connect().execution_options(stream_results=True) as conn: | | yield conn | I'd like to change to the name
connect
as we use this in different taps. See • https://github.com/MeltanoLabs/tap-postgres/blob/5723435f8646f799edff51099fd474b97afb19df/tap_postgres/client.py#L305 • https://github.com/MeltanoLabs/tap-mysql/blob/c84d384ac8cddb2defbf1889128ba1bbdadf3549/tap_mysql/client.py#L68 meltano/sdk