#9457 refactor: Improve docstrings and test coverage for Singer catalog manipulation
Pull request opened by
edgarrmondragon
## Description
## Related Issues
• Closes #XXXX
## Summary by Sourcery
Refactor Singer catalog manipulation by introducing constants, improving type hints, and enriching code documentation, alongside expanded test coverage for selection patterns and metadata rules.
Enhancements:
• Introduce constants for catalog field names and property delimiters to eliminate magic strings
• Refactor code to leverage TypeAlias, override decorator, and conditional typing imports for Python version compatibility
• Add comprehensive docstrings for node types, executors, and visitor functions to clarify catalog traversal and processing
• Unify path handling by using PROP_DELIMITER across catalog matching, parsing, and breadcrumb construction
Tests:
• Add tests for SelectPattern.parse covering various stream and property patterns with negation
• Extend tests for select_metadata_rules to verify rule matching behavior
• Add tests for select_filter_metadata_rules to ensure correct exclusion rule generation
meltano/meltano