GitHub
08/25/2025, 6:48 PMaiodocker dependency optional
Issue created by edgarrmondragon
This dependency is only used for invoking container commands:
meltano/src/meltano/core/container/container_service.py
Lines 52 to 56 in</meltano/meltano/commit/cd77795cf9fbb11286ad0654c3efa2dcb9bd498d|cd77795>
| import aiodocker |
| ---------------------------------------- |
| |
| async with aiodocker.Docker() as docker: |
| if pull: |
| await docker.images.pull(spec.image) |
but it brings a few transitive dependencies with optional C extensions, and thus increased installation time at best for downloading and at worst also for building the binary wheels.
With pipdeptree, we can see what it brings:
meltano==3.5.0
├── aiodocker [required: >=0.22.2,<0.23.0, installed: 0.22.2]
│ └── aiohttp [required: >=3.8, installed: 3.10.2]
│ ├── aiohappyeyeballs [required: >=2.3.0, installed: 2.3.2]
│ ├── aiosignal [required: >=1.1.2, installed: 1.3.1]
│ │ └── frozenlist [required: >=1.1.0, installed: 1.4.1]
│ ├── attrs [required: >=17.3.0, installed: 23.2.0]
│ ├── frozenlist [required: >=1.1.1, installed: 1.4.1]
│ ├── multidict [required: >=4.5,<7.0, installed: 6.0.5]
│ └── yarl [required: >=1.0,<2.0, installed: 1.9.4]
│ ├── idna [required: >=2.0, installed: 3.7]
│ └── multidict [required: >=4.0, installed: 6.0.5]
---
This may be breaking change for anyone relying on this feature, we may wanna defer until v4.
meltano/meltanoGitHub
08/25/2025, 6:48 PMaiodocker dependency optional
Issue closed as completed by edgarrmondragon
meltano/meltano