<#3410 Confusing log messages when setting/unsetti...
# meltano-repo-activity
g
#3410 Confusing log messages when setting/unsetting password settings Issue created by MeltyBot Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/3492 Originally created by @kgpayne on 2022-05-16 151513 --- ### What is the current bug behavior? What is happening now? When setting and then unsetting password kind settings, the behaviour appears to be correct but the logs and messages returned are conflicting/confusing. ### What is the expected correct behavior? What should be happening? • The
set
command should not output warnings about keys that cannot be removed • The
unset
command should output a clear and consistent output message (it unsets all stores where a setting is defined). ### Steps to reproduce How one can reproduce the issue? meltano add extractor tap-gitlab # produces erroneous warnings, but works as expected (value set in .env file) meltano config tap-gitlab set private_token "test 2" # 2022-05-16T142811.512972Z [warning ] Key GITLAB_API_TOKEN not removed from /Users/kp/Projects/demo/interactive-test/.env - key doesn't exist. # Extractor 'tap-gitlab' setting 'private_token' was set in `.env`: 'test 2' # produces erroneous warnings, but appears to work as expected (clears value in .env file) meltano config tap-gitlab unset private_token # 2022-05-16T142857.383895Z [warning ] Key GITLAB_API_TOKEN not removed from /Users/kp/Projects/demo/interactive-test/.env - key doesn't exist. # Extractor 'tap-gitlab' setting 'private_token' in the system database was unset ### Relevant logs and/or screenshots Please use code blocks (```) to format console output ### Possible fixes If you can, link to the line of code that might be responsible for the problem or suggest a fix ### Further regression test Ensure we automatically catch similar issues in the future • Write additional adequate test cases and submit test results • Test results should be reviewed by a person from the team @tayloramurphy @aaronsteers FYI as this may be desirable to fix, or at least investigate further, for 2.0 meltano/meltano