<#3284 bug: Misleading incremental hint when `FULL...
# meltano-repo-activity
g
#3284 bug: Misleading incremental hint when `FULL_TABLE` replication is specified in input catalog metadata for streams that define a replication key Issue created by ReubenFrankel ### Singer SDK Version 0.48.1 ### Is this a regression? • Yes ### Python Version 3.9 or earlier ### Bug scope Taps (catalog, state, etc.) ### Operating System Linux ### Description
employee_schedules
stream implementation: https://github.com/Matatika/tap-peopleware/blob/b45d3e82745f42878f7ccab77a059b64f5ec4583/tap_peopleware/streams.py#L167-L183 Meltano
metadata
override: metadata: employee_schedules: replication-method: FULL_TABLE Resulting catalog entry: { "tap_stream_id": "employee_schedules", "replication_key": "booking_date", "replication_method": "FULL_TABLE", "key_properties": [ "booking_date", "employee_id" ], "schema": {...}, "stream": "employee_schedules", "metadata": [ ... { "breadcrumb": [], "metadata": { "inclusion": "available", "selected": true, "selected-by-default": true, "table-key-properties": [ "booking_date", "employee_id" ], "valid-replication-keys": [ "booking_date" ], "replication-method": "FULL_TABLE" } } ], "selected": true }, Tap stderr: 2025-09-24 152943,790 | INFO | tap-peopleware.employee_schedules | Beginning full_table sync of 'employee_schedules' with context: {'employee_id': 1001} 2025-09-24 152945,823 | INFO | tap-peopleware.employee_schedules | Starting incremental sync with bookmark value: 2025-01-01 It seems a stream defining a
replication_key
is all that is considered when resolving a starting value to write into state: sdk/singer_sdk/streams/core.py Line 476 in</meltano/sdk/commit/d83a8c848bf1af47fa372792713ee616e3515e3c|d83a8c8> | if self.replication_key: | | ------------------------ | I feel like
_write_starting_replication_value
should also take
replication_method
into account i.e. early return if
FULL_TABLE
to avoid logging/writing bookmark value. ### Link to Slack/Linen No response meltano/sdk