#8364 Prototype of stopping after N rows loaded from taps
Pull request opened by
dcowden on <!date^1705595539^{date_short}|2024-01-18T16:32:19Z>
This is a sketch for how i introduced ability to limit rows from taps for the purposes of testing.
Warning: This code has not been executed. I have working code based on an older revision that i tested. So, i know the approach works with code very similar to this. I cleaned up the code to fit into latest meltano main, so that it would be easier to see the essence of the changes.
If this overall path is of interest, i could do more work-- i really would like thoughts about the overall approach before I do that. I dont know the meltano code well at all, so this might be a totally wrong way to do it.
Other notes that might be helpful:
• i first tried a similar approach in the singer runner code, until i realized that was not the code used for meltano run
• This uses an environment var to set the row limit. A much better solution of course would be to allow a property on the project and/or taps, so the row limit can be different for each tap. But (a) I dont know enough to approach that, and (b) for us this is sufficient
• I am worried about whether this code would work in environments with concurrency more than just one. I did not do any testing along those lines.
meltano/meltano