<#9595 chore: Deprecate internally the calling of ...
# meltano-repo-activity
g
#9595 chore: Deprecate internally the calling of dirs methods on `Project` object Pull request opened by edgarrmondragon ## Description ## Related Issues • Closes #XXXX ## Summary by Sourcery Deprecate legacy directory accessor methods on the Project object in favor of the new
dirs
API, introduce a compatibility layer for the deprecated decorator and a custom internal deprecation warning, and update internal code and configuration to ignore these warnings New Features: • Add compatibility module exporting a deprecated decorator and define MeltanoInternalDeprecationWarning Enhancements: • Mark Project methods (root_dir, meltano_dir, venvs_dir, run_dir, logs_dir, job_dir, job_logs_dir, plugin_dir, root_plugins_dir, plugin_lock_path) as internally deprecated in favor of
dirs.*
API • Annotate internal usages of deprecated Project methods with type ignores to suppress warnings CI: • Filter MeltanoInternalDeprecationWarning in CLI startup and pytest configuration • Enable mypy’s deprecated code checks ## Summary by Sourcery Deprecate legacy directory accessor methods on the Project object in favor of the new dirs API, introduce an internal deprecation decorator and warning, and update code and configuration to suppress these warnings Enhancements: • Add a compatibility module exporting a deprecated decorator and define MeltanoInternalDeprecationWarning • Mark all legacy Project directory methods as internally deprecated and redirect them to the new dirs API • Annotate internal usages of deprecated Project methods with ignore directives to suppress warnings CI: • Filter MeltanoInternalDeprecationWarning in CLI startup and pytest configuration • Enable mypy’s deprecated-code checks Chores: • Remove the unused make_meltano_secret_dir method in config_service meltano/meltano