<#3669 fix: validate config string formats> Pull r...
# meltano-repo-activity
g
#3669 fix: validate config string formats Pull request opened by Dexter2099 Fixes #1451. Summary • Enable JSON Schema format checking when validating plugin configuration. • Add regression coverage showing an invalid
date-time
config value raises
ConfigValidationError
. • Update the shared core test tap fixture to use a valid RFC3339
date-time
value for
start_date
. Validation •
uv run pytest tests/core/test_tap_class.py::test_config_errors -q
•
uv run pytest tests/core/test_tap_class.py tests/core/test_target_class.py tests/core/test_plugin_base.py tests/core/test_plugin_config.py tests/core/test_jsonschema_helpers.py -q
•
uv run pytest tests/core -q
•
pre-commit run --files singer_sdk/plugin_base.py tests/core/test_tap_class.py tests/core/conftest.py tests/core/test_streams.py
•
NOX_DEFAULT_VENV_BACKEND=uv nox -rs tests-3.11 -- tests/core
Summary by Sourcery Enable strict JSON Schema format validation for plugin configuration and align tests with RFC3339-compliant date-time values. Bug Fixes: • Ensure configuration validation checks JSON Schema formats such as date-time when validating plugin configs. Tests: • Add regression coverage for invalid date-time configuration values and update core tap/stream test fixtures to use RFC3339-compliant start_date values. meltano/sdk