<#3697 fix: Make the `Sink.clean_up()` method a no...
# meltano-repo-activity
g
#3697 fix: Make the `Sink.clean_up()` method a no-op by default Pull request opened by edgarrmondragon This is to avoid forcing users to call
super().clean_up()
in their implementation. TIL that this called the "Template Method", and it is something we should probably do in most of our explicitly public APIs. Summary by Sourcery Introduce a finalized sink shutdown step that preserves metrics behavior while making
clean_up()
a no-op by default. Enhancements: • Add a final
_clean_up()
method on sinks to handle end-of-stream cleanup and metric exit calls. • Change target draining logic to invoke the new sink
_clean_up()
method instead of
clean_up()
. Build: • Update Ruff pre-commit hook and required Ruff version to 0.15.21 in tooling configuration. meltano/sdk