Hello, first time posting! Question about `tap-git...
# contributing
p
Hello, first time posting! Question about
tap-github
(MeltanoLabs variant). The issues stream seems to overwrite the record's
type
field with "issue"/"pull_request", which makes GitHub's native issue type (
type.name
, e.g. "Bug" or custom org types) inaccessible, or so far as I can tell. Since the value gets reassigned inside the tap before records are emitted, schema overrides / stream maps can't recover it downstream. Would love to be able to fix this in the code, but wanted to check if I'm thinking about it right.
✅ 1
❤️ 1
e
Yeah, you're right. I opened github.com/MeltanoLabs/tap-github/pull/600, but that's a slight breaking change so I wonder if we should preserve the existing
type
field and map the one coming from the API into something like
issue_type
. Thoughts?
p
Hi Edgar, thanks for the PR! I don't have strong opinions, but I think something like this will inevitably be a breaking change at some point.
e
I erred on the side of caution and did what I described above: github.com/MeltanoLabs/tap-github/…/v1.29.1
p
Great, thanks so much!